Re: [PATCHv2] staging: rtl8723bs: do not use __constant_cpu_to_le16

From: Sergey Senozhatsky
Date: Sun Mar 17 2019 - 11:16:39 EST


On (03/17/19 13:16), Greg Kroah-Hartman wrote:
> On Sun, Mar 17, 2019 at 08:48:03PM +0900, Sergey Senozhatsky wrote:
> > From: Sergey Senozhatsky <sergey.senozhatsky.work@xxxxxxxxx>
>
> Why ".work"?

Aha, good question. There is not so much of a difference between .work and
!.work. (if any at all).

> > cpu_to_le16() is capable enough to detect __builtin_constant_p()
> > and to use an appropriate compile time ___constant_swahbXX()
> > function.
> >
> > So we can use cpu_to_le16() instead of __constant_cpu_to_le16().
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
>
> Email address does not match up to the From: line above :(

Greg, sorry about that!
Either you were the first one to complaint or this was the first time
I re-rent a patch from a different google account.

-ss