Re: [PATCH] hostfs: fix mismatch between link_file definition and declaration

From: Colin Ian King
Date: Mon Mar 18 2019 - 04:41:38 EST


On 17/03/2019 23:49, Richard Weinberger wrote:
> Am Montag, 18. MÃrz 2019, 00:09:09 CET schrieb Colin King:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> The function link_file declaration in the header file has the order
>> of the two arguments (from, to) swapped when compared to the definition
>> arguments of (to, from). Fix this by swapping them around to match
>> the definition.
>>
>> This error predates the git history, so no idea when this error
>> was introduced.
>
> commit bf4f804738544a95b8bc8d6a7e2629c3fc0240dd
> Author: jdike <jdike>
> Date: Sat Dec 9 22:52:44 2000 +0000
>
> hostfs now mostly works. Almost all of the common operations are now
> implemented, the main exceptions being mknod and executing files from
> a hostfs filesystem.
>
> Enough archaeology for today. :-)

Nice. How do you find these ancient git commits?

>
> Thanks,
> //richard
>
>