Re: [PATCH 1/5] reset: add acquired/released state for exclusive reset controls

[Thierry Reding]

On Mon, Mar 18, 2019 at 05:40:50PM +0100, Philipp Zabel wrote:
> Hi Thierry,
> 
> On Mon, 2019-03-18 at 10:12 +0100, Thierry Reding wrote:
> > On Thu, Feb 21, 2019 at 04:28:58PM +0100, Thierry Reding wrote:
> > > On Thu, Feb 21, 2019 at 04:25:53PM +0100, Thierry Reding wrote:
> > > > From: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > > > 
> > > > There are cases where a driver needs explicit control over a reset line
> > > > that is exclusively conneted to its device, but this control has to be
> > > > temporarily handed over to the power domain controller to handle reset
> > > > requirements during power transitions.
> > > > Allow multiple exclusive reset controls to be requested in 'released'
> > > > state for the same physical reset line, only one of which can be
> > > > acquired at the same time.
> > > > 
> > > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> > > > ---
> > > >  drivers/reset/core.c  | 139 ++++++++++++++++++++++++++++++++++++++----
> > > >  include/linux/reset.h |  93 ++++++++++++++++++++++------
> > > >  2 files changed, 200 insertions(+), 32 deletions(-)
> > > 
> > > Hi Philipp,
> > > 
> > > the bulk of this is unchanged relative to what you had posted
> > > originally. I squashed in the few things that we had already discussed
> > > earlier (EINVAL -> EPERM) and a couple of minor fixes for issues that I
> > > found while working with this.
> > > 
> > > Attached is my fixup patch which contains all the changes I made on top
> > > of your version and that I squashed into this.
> > > 
> > > Thierry
> > 
> > Hi Philipp,
> > 
> > do you have any further comments on this series?
> 
> Sorry for the delay, I'll have a closer look tomorrow. I obviously don't
> disagree on the implementation and I appreciate the added documentation.
> 
> As for how to merge this, would you be fine with me providing a stable
> branch that contains the first three patches? That could then go into
> both reset/next and tegra trees.

Yeah, that's fine with me.

Thanks,
Thierry

Attachment: signature.asc
Description: PGP signature