RE: [PATCH RESEND V6 0/5] Add i.MX7ULP EVK PWM backlight support

From: Anson Huang
Date: Tue Mar 19 2019 - 05:12:26 EST


Hi,

Best Regards!
Anson Huang

> -----Original Message-----
> From: Uwe Kleine-KÃnig [mailto:u.kleine-koenig@xxxxxxxxxxxxxx]
> Sent: 2019å3æ19æ 16:15
> To: Anson Huang <anson.huang@xxxxxxx>
> Cc: thierry.reding@xxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; linux@xxxxxxxxxxxxxxx; stefan@xxxxxxxx;
> otavio@xxxxxxxxxxxxxxxx; Leonard Crestez <leonard.crestez@xxxxxxx>;
> schnitzeltony@xxxxxxxxx; jan.tuerk@xxxxxxxxxxx; Robin Gong
> <yibin.gong@xxxxxxx>; linux-pwm@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH RESEND V6 0/5] Add i.MX7ULP EVK PWM backlight
> support
>
> On Tue, Mar 19, 2019 at 07:09:56AM +0000, Anson Huang wrote:
> > i.MX7ULP EVK board has MIPI-DSI display, its backlight is supplied by
> > TPM PWM module, this patch set enables i.MX7ULP TPM PWM driver
> support
> > and also add backlight support for MIPI-DSI display.
>
> Given that you actually changed something compared to v6, this is not a
> resend but v7. Also I suggest to practise a bit of patience before sending out
> a new revision to prevent people still looking at the previous round. I just
> gave feedback to the original v6 which you obviously didn't address :-|
>
> Also a highlevel changelog for the series (here something like: "Properly
> separate dt changes into soc-specific and machine-specific changes") is
> helpful.

OK, will pay attention to that, the resend is just because the patch content is NOT
Changed, just re-organize the DT patch.

Also, I understand that sending the patch version too quickly will result in too many
Patch version in this thread, but I just want to address the comments ASAP when I
Have time, hope that does NOT bother reviewer too much...

Thanks for your patience!
Anson.

>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-KÃnig |
> Industrial Linux Solutions |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
> engutronix.de%2F&amp;data=02%7C01%7Canson.huang%40nxp.com%7C4f1
> ff94e2e2a44199d3808d6ac42f916%7C686ea1d3bc2b4c6fa92cd99c5c301635%
> 7C0%7C0%7C636885800978790824&amp;sdata=p%2FK3suruuBFRPnW8nZ%2
> BFZplV2r0i22N6Jq4Hi7DBwp4%3D&amp;reserved=0 |