Re: [PATCH v3] ARM: tegra: enforce PM requirement

From: Sameer Pujar
Date: Wed Mar 20 2019 - 00:18:32 EST



On 2/27/2019 7:01 PM, Dmitry Osipenko wrote:
27.02.2019 11:20, Sameer Pujar ÐÐÑÐÑ:
Currently runtime PM is enabled for Tegra HDA driver. One of the concern
raised was about handling !PM case in HDA driver. In this case, there is
a need to manage clocks and power explicitly in the driver and reviewers
were not really convinced about this. The consensus at the end was to
enforce PM requirement to keep things simple, rather driver mentioning a
dependency on PM. This is how it is done for ARM 64-bit Tegra platforms
and the same can be done for 32-bit Tegra platforms too.

Finally the objective is to remove dependency on PM availability for all
Tegra drivers. The detailed discussion can be found in following patch,
https://patchwork.ozlabs.org/patch/1031007/

Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Reviewed-by: Jonathan Hunter <jonathanh@xxxxxxxxxx>
---
The commit message is okay to me this time, thanks! I'm still not super-happy to lose the !PM option because of its value in regards to the PM debugging, but again we can just do something better in that regards later on if will be really needed.

Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>
Do we have any further concerns over the patch? Request maintainers for merge otherwise.