Re: [PATCH] can: flexcan: bump FLEXCAN_TIMEOUT_US to 250

From: Marc Kleine-Budde
Date: Wed Mar 20 2019 - 09:18:13 EST


On 3/7/19 4:00 PM, Rasmus Villemoes wrote:
> While trying to add support for the Flexcan modules on the MPC8309,
> I'm hitting ETIMEDOUT in flexcan_chip_disable(). With this, probing
> succeeds. Checking the leftover value of timeout with a primitive
>
> pr_err("%s: timeout==%d\n", __func__, timeout);
>
> after the loop in chip_disable() typically shows values around 12-14,
> i.e. suggesting that it takes about 110-130 us for the LPM_ACK bit to
> appear. So a timeout value of about twice that seems reasonable.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx>

I've scheduled the patch by Joakim Zhang:

9daed89ae8a3 can: flexcan: fix timeout when set small bitrate

that doubles the timeout to 100.

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

Attachment: signature.asc
Description: OpenPGP digital signature