Re: [PATCH -next] ipmi: Make ipmi_interfaces_srcu variable static

From: Corey Minyard
Date: Thu Mar 21 2019 - 08:27:50 EST


On Wed, Mar 20, 2019 at 09:35:05PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@xxxxxxxxxx>
>
> Fix sparse warning:
>
> drivers/char/ipmi/ipmi_msghandler.c:635:20: warning:
> symbol 'ipmi_interfaces_srcu' was not declared. Should it be static?

Queued for Linux 5.1. Thanks

-corey

>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index c35f2bc..7ebdde4 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -632,7 +632,7 @@ static DEFINE_MUTEX(ipmidriver_mutex);
>
> static LIST_HEAD(ipmi_interfaces);
> static DEFINE_MUTEX(ipmi_interfaces_mutex);
> -struct srcu_struct ipmi_interfaces_srcu;
> +static struct srcu_struct ipmi_interfaces_srcu;
>
> /*
> * List of watchers that want to know when smi's are added and deleted.
> --
> 2.7.0
>
>