Re: [possible PATCH] crypto: sahara - Use #ifdef DEBUG not IS_ENABLED(DEBUG)
From: Ard Biesheuvel
Date: Fri Mar 22 2019 - 10:30:14 EST
On Fri, 22 Mar 2019 at 13:43, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Mar 07, 2019 at 04:15:55PM -0800, Joe Perches wrote:
> > Normal use of IS_ENABLED is with a CONFIG_<SYMBOL> and
> > there is no -DDEBUG in the Makefile here.
> > Replace the IS_ENABLED(DEBUG) with #ifdef DEBUG/#endif
> > blocks.
> > Miscellanea:
> > o Move the sahara_state array into the function that uses it.
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > ---
> > drivers/crypto/sahara.c | 20 +++++++++-----------
> > 1 file changed, 9 insertions(+), 11 deletions(-)
> Even if this is correct this is way too ugly. The original code
> at least compiled everything regardless of macros. Your new code
> won't detect compile errors in debugging code unless debugging is
What's wrong with IS_ENABLED(DEBUG) anyway? It may not be 'normal use'
but it works fine.