Re: [PATCH 1/3 v9] x86/mm: Change the examination condition to avoid confusion
From: Borislav Petkov
Date: Fri Mar 22 2019 - 13:51:13 EST
On Thu, Mar 21, 2019 at 06:33:07PM +0800, Lianbo Jiang wrote:
> Following the commit <0e4c12b45aa8> ("x86/mm, resource: Use
> PAGE_KERNEL protection for ioremap of memory pages"),
The proper commit quotation format is done by adding this to your
abbrev = 12
one = show -s --pretty='format:%h (\"%s\")'
and then doing:
$ git one <commit id>
which will give you
0e4c12b45aa8 ("x86/mm, resource: Use PAGE_KERNEL protection for ioremap of memory pages")
> here it is really checking for the 'IORES_DESC_ACPI_*' values.
Well, it is not really checking that.
> Therefore, it is necessary to change the examination condition
> to avoid confusion.
The justification for that change sounds really fishy.
Good mailing practices for 400: avoid top-posting and trim the reply.