Re: [PATCH] pinctrl: intel: Implements gpio free function

[Enrico Weigelt, metux IT consult]

On 21.03.19 14:56, Mika Westerberg wrote:
> I checked it and you do this:> > +       value |= PADCFG0_GPIORXDIS;> +       value &=
~PADCFG0_GPIOTXDIS;> > which pretty much turns the pin GPIO output
unconditionally. I don't> really think it is good idea. May work in your
case but may cause> problems with others.
Uh, please don't do this. In some cases it could be even dangerous.

In general, I'd question whether such an gpio should be userland-
controlled in the first place. Better write a driver for it, which
also handles the reset properly.


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287