Re: [RESEND PATCH v6 09/11] leds: max77650: add LEDs support

From: Jacek Anaszewski
Date: Fri Mar 22 2019 - 15:40:54 EST

On 3/22/19 10:53 AM, Bartosz Golaszewski wrote:
pt., 22 mar 2019 o 10:21 Pavel Machek <pavel@xxxxxx> napisaÅ(a):

On Mon 2019-03-18 18:42:26, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>

This adds basic support for LEDs for the max77650 PMIC. The device has
three current sinks for driving LEDs.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
Acked-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>

Acked-by: Pavel Machek <pavel@xxxxxx>

+ label = of_get_property(child, "label", NULL);
+ if (!label) {
+ led-> = "max77650::";
+ } else {
+ led-> = devm_kasprintf(dev, GFP_KERNEL,
+ "max77650:%s", label);
+ if (!led->
+ return -ENOMEM;
+ }

I'd rather not have the "max77650:" prefix in the LED name (as it is

I was instructed to do so by the LED subsystem maintainer.

Yes, let's keep things consistent, we will convert it to use generic
support for LED naming once that support is merged.

Best regards,
Jacek Anaszewski