RE: [PATCH v3 2/3] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models
From: Ghannam, Yazen
Date: Fri Mar 22 2019 - 17:35:49 EST
> -----Original Message-----
> From: linux-edac-owner@xxxxxxxxxxxxxxx <linux-edac-owner@xxxxxxxxxxxxxxx> On Behalf Of Borislav Petkov
> Sent: Friday, March 22, 2019 3:55 PM
> To: Ghannam, Yazen <Yazen.Ghannam@xxxxxxx>
> Cc: linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; tony.luck@xxxxxxxxx; x86@xxxxxxxxxx; rafal@xxxxxxxxxx;
> Subject: Re: [PATCH v3 2/3] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models
> On Fri, Mar 22, 2019 at 08:37:08PM +0000, Ghannam, Yazen wrote:
> > Sorry, I forgot to mention this. I went with "filter_mce_amd" because
> > amd_filter_mce() is already defined in edac/mce_amd.c and there was
> > a conflict when building. Is there another way to avoid these naming
> > conflicts?
> Yuck, we're clearly filtering too much. :)
> So let's rename that amd_filter_mce() to something else since it is
> static and only used in that file. Maybe something like
> if (ignore_mce(m))
> return NOTIFY_STOP;
> so that we can keep the "filter" notion all reserved to the core MCA
> code and there's no confusion.
> And then amd_filter_mce() is free to be used in the core code.
Okay, will do.
Should this be a pre-patch, or just include it here?