Re: [PATCH 3/3] net: ethernet: ti: fix possible object reference leak

From: David Miller
Date: Sat Mar 23 2019 - 21:22:05 EST


From: Wen Yang <wen.yang99@xxxxxxxxxx>
Date: Fri, 22 Mar 2019 11:04:09 +0800

> The call to of_get_child_by_name returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
>
> Detected by coccinelle with the following warnings:
> ./drivers/net/ethernet/ti/netcp_ethss.c:3661:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3654, but without a corresponding object release within this function.
> ./drivers/net/ethernet/ti/netcp_ethss.c:3665:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3654, but without a corresponding object release within this function.
>
> Signed-off-by: Wen Yang <wen.yang99@xxxxxxxxxx>

Applied.