[PATCH 0/1] pwm: meson: fix scheduling while atomic issue
From: Martin Blumenstingl
Date: Sun Mar 24 2019 - 18:09:36 EST
Back in January a "BUG: scheduling while atomic" error showed up during
boot on my Meson8b Odroid-C1 (which uses a PWM regulator as CPU supply).
The call trace comes down to:
Jerome has also seen the same problem but from pwm-leds (instead of a
pwm-regulator). He posted a patch which replaces the spinlock with a
mutex. That works. I believe we can optimize this by reducing the time
where the lock is held - that also allows to keep the spin-lock.
Analyzing this issue helped me understand the pwm-meson driver better.
My plan is to send some cleanups (with the goal of re-using more of the
goodies from the PWM core in the pwm-meson driver) after this single fix
is merged (they can be found here: ).
Target version: please queue this for -fixes so it makes it's way into
v5.1-rc (so we can get it backported from there, because this issue has
existed since the pwm-meson driver was introduced).
Martin Blumenstingl (1):
pwm: meson: use the spin-lock only to protect register modifications
drivers/pwm/pwm-meson.c | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)