Re: [PATCH] x86, retpolines: entirely disable switch jump tables when retpolines are enabled

From: David Woodhouse
Date: Mon Mar 25 2019 - 10:29:21 EST


On Mon, 2019-03-25 at 14:56 +0100, Daniel Borkmann wrote:
> More than 20 switch cases are not expected to be fast-path critical, but
> it would still be good to align with gcc behavior for versions < 8.4.0 in
> order to have consistency across supported gcc versions. vmlinux size is
> slightly growing by 0.27% for older gcc. This flag is only set to work
> around affected gcc, no change for clang.

I note your final sentence doesn't actually say that clang doesn't have
this problem, and doesn't *need* this (or an equivalent) change.

It should say that (if it's true). And if it isn't true, then other
remedial action would be in order.

Attachment: smime.p7s
Description: S/MIME cryptographic signature