Re: [PATCH v2 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver

From: Sakari Ailus
Date: Tue Mar 26 2019 - 07:34:45 EST


Hi Mickael,

On Mon, Mar 25, 2019 at 12:22:17PM +0000, Mickael GUENE wrote:
...
> >> + /* register it for later use */
> >> + bridge->rx = ep;
> >> + bridge->rx.link_frequencies = ep.nr_of_link_frequencies == 1 ?
> >> + &bridge->link_frequency : NULL;
> >
> > I think you need to simply ignore the link frequencies here. The
> > transmitting device can tell the frequency based on its configuration
> > (based on the link frequencies). You seem to have implemented that already.
> >
> Idea of this was to allow some support for sensor that doesn't implement
> V4L2_CID_PIXEL_RATE. Do you think it's useless ?

Sensor drivers need to be amended with support for that control.

--
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx