Re: [PATCH RESEND v3] tpm: fix an invalid condition in tpm_common_poll
From: Tadeusz Struk
Date: Tue Mar 26 2019 - 11:58:31 EST
On 3/25/19 7:09 AM, Jarkko Sakkinen wrote:
> It is still missing the comment I asked to add. Otherwise, it is good.
Sorry, I didn't see your email with the suggestion earlier.
To be honest I'm not sure if this comment adds much value, or if it is
even correct. The poll doesn't "succeed" or "fail". It just returns
a mask indicating if there is any data to read or if the user can write.
Isn't the commit message + 'git blame' enough to remember why it was
done this way?