Re: [PATCH ghak109 V2] audit: link integrity evm_write_xattrs record to syscall event

From: Mimi Zohar
Date: Tue Mar 26 2019 - 16:40:52 EST


Hi Richard, Paul,

On Tue, 2019-03-26 at 14:49 -0400, Richard Guy Briggs wrote:
> In commit fa516b66a1bf ("EVM: Allow runtime modification of the set of
> verified xattrs"), the call to audit_log_start() is missing a context to
> link it to an audit event. Since this event is in user context, add
> the process' syscall context to the record.
>
> In addition, the orphaned keyword "locked" appears in the record.
> Normalize this by changing it to logging the locking string "." as any
> other user input in the "xattr=" field.
>
> Please see the github issue
> https://github.com/linux-audit/audit-kernel/issues/109
>
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>

Acked-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>

Paul, were you planning on upstreaming this patch?

Mimi