Re: [PATCH v4 2/2] staging: mt7621-mmc: Initialize completions a single time during probe

From: George Hilliard
Date: Tue Mar 26 2019 - 21:46:55 EST


On Tue, Mar 26, 2019 at 6:46 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Mar 26, 2019 at 09:21:39AM -0600, George Hilliard wrote:
> > - init_completion(&host->cmd_done);
> > + // The completion should have been consumed by the previous command
> > + // response handler, because the mmc requests should be serialized
> > + if(completion_done(&host->cmd_done))
>
> Did you run your patch through checkpatch.pl? It should have reported
> an error here :(

No, I didn't. My mistake, sorry. Will fix up and resend again.

George