Re: [PATCH] scsi: libcxgbi: remove uninitialized variable len

From: Martin K. Petersen
Date: Wed Mar 27 2019 - 21:00:08 EST



Colin,

> The variable len is not being inintialized and the uninitialized value
> is being returned. However, this return path is never reached because
> the default case in the switch statement returns -ENOSYS. Clean up
> the code by replacing the return -ENOSYS with a break for the default
> case and returning -ENOSYS at the end of the function. This allows
> len to be removed.

Not a fan of this ENOSYS business but I guess it's been that way
forever. Applied to 5.2/scsi-queue, thanks.

--
Martin K. Petersen Oracle Linux Engineering