Re: [linux-sunxi] [PATCH] ARM: dts: sun8i: a83t: Add missing cooling device properties for CPUs

From: Chen-Yu Tsai
Date: Thu Mar 28 2019 - 04:04:52 EST


On Wed, Mar 27, 2019 at 8:49 AM megous via linux-sunxi
<linux-sunxi@xxxxxxxxxxxxxxxx> wrote:
>
> From: Ondrej Jirman <megous@xxxxxxxxxx>
>
> This is inspired by the similar patch for H3. Original description
> applies, and is copied below:
>
> The cooling device properties, like "#cooling-cells" and
> "dynamic-power-coefficient", should either be present for all the CPUs
> of a cluster or none. If these are present only for a subset of CPUs of
> a cluster then things will start falling apart as soon as the CPUs are
> brought online in a different order. For example, this will happen
> because the operating system looks for such properties in the CPU node
> it is trying to bring up, so that it can register a cooling device.
>
> Add such missing properties.
>
> Fix other missing properties (clocks, clock-names) as well to make it all
> work.

Could you split this out into a separate patch? It actually touches more
lines than the primary part of your patch.

ChenYu