Re: [PATCH V2] drm/atomic-helper: Make atomic_enable/disable crtc callbacks optional
From: Gerd Hoffmann
Date: Fri Mar 29 2019 - 06:58:26 EST
On Tue, Mar 26, 2019 at 08:50:03AM +0100, Daniel Vetter wrote:
> On Mon, Mar 25, 2019 at 08:29:06AM -0300, Rodrigo Siqueira wrote:
> > On 03/15, Daniel Vetter wrote:
> > > On Thu, Mar 14, 2019 at 03:48:45PM -0300, Rodrigo Siqueira wrote:
> > > > Allow atomic_enable and atomic_disable operations from
> > > > drm_crtc_helper_funcs struct optional. With this, the target display
> > > > drivers don't need to define a dummy function if they don't need one.
> > > >
> > > > Changes since v2:
> > > > * Don't make funcs optional
> > > > * Update kerneldoc for atomic_enable/disable
> > > > * Replace "if (funcs->atomic_enable)" by "if (funcs->commit)"
> > > > * Improve commit message
> > > >
> > > > Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx>
> > >
> > > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Hi,
> > Is it ok if I apply this patch?
Hmm, seems to not be applied yet. Pushed to drm-misc-fixes.