Re: [PATCH 2/7] irqchip/alpine-msi: Update driver license to use SPDX

From: David Woodhouse
Date: Mon Apr 01 2019 - 07:53:16 EST


On Sun, 2019-03-31 at 18:16 +0530, Mukesh Ojha wrote:
> On 3/31/2019 6:04 PM, Hanna Hawa wrote:
> > Update driver license to be in-line with Linux conventions.
> >
> > Signed-off-by: Hanna Hawa <hhhawa@xxxxxxxxxx>
> > ---
> > drivers/irqchip/irq-alpine-msi.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-alpine-msi.c
> > b/drivers/irqchip/irq-alpine-msi.c
> > index ae2fca7..ec6a606 100644
> > --- a/drivers/irqchip/irq-alpine-msi.c
> > +++ b/drivers/irqchip/irq-alpine-msi.c
> > @@ -1,13 +1,10 @@
> > +// SPDX-License-Identifier: GPL-2.0
>
>
> Please fix this as per.
> https://lkml.org/lkml/2019/2/13/570

I find myself struggling to care. And that was even before I spotted:

$ grep -A6 "Style" Documentation/process/license-rules.rst
2. Style:

The SPDX license identifier is added in form of a comment. The comment
style depends on the file type::

C source: // SPDX-License-Identifier: <SPDX License Expression>
C header: /* SPDX-License-Identifier: <SPDX License Expression> */


Attachment: smime.p7s
Description: S/MIME cryptographic signature