[PATCH 5.0 111/146] gpio: exar: add a check for the return value of ida_simple_get fails

From: Greg Kroah-Hartman
Date: Mon Apr 01 2019 - 14:08:41 EST


5.0-stable review patch. If anyone has any objections, please let me know.

------------------

From: Kangjie Lu <kjlu@xxxxxxx>

commit 7ecced0934e574b528a1ba6c237731e682216a74 upstream.

ida_simple_get may fail and return a negative error number.
The fix checks its return value; if it fails, go to err_destroy.

Cc: <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
drivers/gpio/gpio-exar.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/gpio/gpio-exar.c
+++ b/drivers/gpio/gpio-exar.c
@@ -148,6 +148,8 @@ static int gpio_exar_probe(struct platfo
mutex_init(&exar_gpio->lock);

index = ida_simple_get(&ida_index, 0, 0, GFP_KERNEL);
+ if (index < 0)
+ goto err_destroy;

sprintf(exar_gpio->name, "exar_gpio%d", index);
exar_gpio->gpio_chip.label = exar_gpio->name;