Re: [PATCH v11 4/8] dt-bindings: mfd: Document first ROHM BD70528 bindings
From: Matti Vaittinen
Date: Wed Apr 03 2019 - 05:04:15 EST
And thanks again for fixing the language. Appreciated!
On Wed, Apr 03, 2019 at 08:34:26AM +0100, Lee Jones wrote:
> On Mon, 25 Mar 2019, Matti Vaittinen wrote:
> > Document bindings for regulators (3 bucks, 3 LDOs and 2 LED
> > drivers) and 4 GPIO pins which can be configured for I/O or
> > as interrupt sources withe configurable trigger levels.
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > ---
> > .../bindings/mfd/rohm,bd70528-pmic.txt | 102 ++++++++++++++++++
> > 1 file changed, 102 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> > new file mode 100644
> > index 000000000000..120462c17904
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> > @@ -0,0 +1,102 @@
> > +* ROHM BD70528 Power Management Integrated Circuit bindings
> > +
> > +BD70528MWV is an ultra-low quiescet current general purpose single-chip
> What does 'quiescet' mean?
I guess you knew what I meant =) Quiescent - I'll fix the typo.
> "general purpose, single-chip,"
Rules for using commas are far beyond my skills. I was bad in it at
Finnish classes. Not to even mention English. Actually, the teacher
suggested us to rather leave out the commas than trying to place them
correctly in English sentences. Guess the rules are not that simple =)
So I'll just add them as you suggested =)
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~