Re: [PATCH net-next 01/12] net: hns3: check 1000M half for hns3_ethtool_ops.set_link_ksettings

[tanhuazhong]

On 2019/4/3 17:12, Sergei Shtylyov wrote:
> Hello!
>
> On 03.04.2019 6:07, Huazhong Tan wrote:
>
> > From: Peng Li <lipeng321@xxxxxxxxxx>
> >
> > Hip08 SOC does not support 1000M half, this patch adds 1000M half
> > check for hns3_ethtool_ops.set_link_ksettings, so the user can not
> > set 1000M half by ethtool.
> >
> > Signed-off-by: Peng Li <lipeng321@xxxxxxxxxx>
> > Signed-off-by: Huazhong Tan <tanhuazhong@xxxxxxxxxx>
> > ---
> > Â drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 4 ++++
> > Â 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c 
> > b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> > index 359d473..0c05807 100644
> > --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> > @@ -648,6 +648,10 @@ static int hns3_get_link_ksettings(struct 
> > net_device *netdev,
> > Â static int hns3_set_link_ksettings(struct net_device *netdev,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ const struct ethtool_link_ksettings *cmd)
> > Â {
> > +ÂÂÂ /* Chip don't support this mode. */
>
>  ÂÂ Doesn't.
>
> [...]
>
> MBR, Sergei

ok, thanks.

> .