Re: [PATCH] psi: Clarify the units used in pressure files
From: Waiman Long
Date: Wed Apr 03 2019 - 09:59:31 EST
On 04/02/2019 05:18 PM, Johannes Weiner wrote:
> On Tue, Apr 02, 2019 at 03:38:10PM -0400, Waiman Long wrote:
>> The output of the PSI files show a bunch of numbers with no unit.
>> The psi.txt documentation file also does not indicate what units
>> are used. One can only find out by looking at the source code. The
>> units are percentage for the averages and useconds for the total.
>> Make the information easier to find by documenting the units in psi.txt.
>> Signed-off-by: Waiman Long <longman@xxxxxxxxxx>
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> Thanks Waiman!
I had thought about changing the message to show the units somehow, but
that may break existing applications that have dependency on the current
format. So documenting them in psi.txt is the best I can think of.