Re: dell_smbios KASAN bug

From: Steven Rostedt
Date: Wed Apr 03 2019 - 13:16:59 EST


On Mon, 25 Mar 2019 11:20:47 -0500
Tom Zanussi <tzanussi@xxxxxxxxx> wrote:

> > Is it OK if I add the following tags to that patch?
> >
> > Reported-by: Tom Zanussi <tzanussi@xxxxxxxxx>
> > Tested-by: Tom Zanussi <tzanussi@xxxxxxxxx>
> >
>
> Yep, fine with me.

I modified the patch slightly. Can you test this too. There should be
no reason that it wont work as this is "safer" but I don't want to put
your tested-by if you haven't tested it ;-)

-- Steve

diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
index 0537d44d45a6..a74c0df25b15 100644
--- a/drivers/platform/x86/dell-smbios-base.c
+++ b/drivers/platform/x86/dell-smbios-base.c
@@ -625,6 +625,8 @@ static int __init dell_smbios_init(void)

fail_platform_driver:
kfree(da_tokens);
+ da_tokens = NULL;
+ da_num_tokens = 0;
return ret;
}