Re: [PATCH 4/5] mfd: ti-lmu: Remove support for LM3697

From: Dan Murphy
Date: Thu Apr 04 2019 - 08:09:24 EST


Lee

Thanks for the review

On 4/4/19 3:17 AM, Lee Jones wrote:
> On Mon, 25 Mar 2019, Dan Murphy wrote:
>
>> Remove support for the LM3697 from the ti-lmu
>
> Bit of an odd place to insert a line feed.
>

I will fix in v2.

>> driver in favor of a dedicated LED driver.
>>
>> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
>> ---
>> drivers/leds/Kconfig | 2 +-
>> drivers/mfd/Kconfig | 2 +-
>> drivers/mfd/ti-lmu.c | 17 -----------
>> include/linux/mfd/ti-lmu-register.h | 44 -----------------------------
>> include/linux/mfd/ti-lmu.h | 1 -
>> 5 files changed, 2 insertions(+), 64 deletions(-)
>
> I'm fine with the patch.
>
> Can you edit drivers/leds/Kconfig as part of a separate patch please?
> Keeping this in sync with this change is not critical and would add a
> whole bunch of process which we can really do without.
>

Ack. I will add this when I add the LM3697 config in the Kconfig

Dan

--
------------------
Dan Murphy