Re: [PATCH 3/6 v3] riscv: Fix syscall_get_arguments() and syscall_set_arguments()

From: Palmer Dabbelt
Date: Thu Apr 04 2019 - 19:29:46 EST

On Thu, 04 Apr 2019 07:26:53 PDT (-0700), rostedt@xxxxxxxxxxx wrote:
On Thu, 4 Apr 2019 17:02:10 +0300
"Dmitry V. Levin" <ldv@xxxxxxxxxxxx> wrote:

On Mon, Apr 01, 2019 at 09:41:07AM -0400, Steven Rostedt wrote:
> From: "Dmitry V. Levin" <ldv@xxxxxxxxxxxx>
> RISC-V syscall arguments are located in orig_a0,a1..a5 fields
> of struct pt_regs.
> Due to an off-by-one bug and a bug in pointer arithmetic
> syscall_get_arguments() was reading s3..s7 fields instead of a1..a5.
> Likewise, syscall_set_arguments() was writing s3..s7 fields
> instead of a1..a5.
> Link:
> Fixes: e2c0cdfba7f69 ("RISC-V: User-facing API")
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> Cc: Will Drewry <wad@xxxxxxxxxxxx>
> Cc: Palmer Dabbelt <palmer@xxxxxxxxxx>
> Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
> Cc: stable@xxxxxxxxxxxxxxx # v4.15+
> Signed-off-by: Dmitry V. Levin <ldv@xxxxxxxxxxxx>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

According to
the following tag could be added to this patch:

Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxx>

That link isn't actually an ack. Palmer, you OK if I add it?

Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxx> (for the RISC-V parts)