Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses

From: Eric Dumazet
Date: Fri Apr 05 2019 - 05:23:50 EST




On 04/04/2019 11:55 AM, Lawrence Brakmo wrote:
>
> The module parameter, even if enabled by default, would have been
> preferable since it would support environments where this feature
> turned out to be sub-optimal.

Module parameters are awful, just add a sysctl if you need.

Bonus : per netns thing, meaning writing tests (say with packetdrill) is easier,
since you can launch dozens of them in parallel, each one in a different netns.