Re: [PATCH v3 10/25] dt-bindings: lp8860: Add function and color properties
From: Dan Murphy
Date: Fri Apr 05 2019 - 07:48:05 EST
Jacek
On 3/31/19 12:54 PM, Jacek Anaszewski wrote:
> Refer to new "function" and "color" properties and mark "label"
> as deprecated.
>
> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
> Cc: Dan Murphy <dmurphy@xxxxxx>
> ---
> Documentation/devicetree/bindings/leds/leds-lp8860.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> index 5f0e892ad759..9863220db4ba 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> @@ -20,12 +20,16 @@ Required child properties:
> - reg : 0
>
> Optional child properties:
> - - label : see Documentation/devicetree/bindings/leds/common.txt
> + - function : see Documentation/devicetree/bindings/leds/common.txt
> + - color : see Documentation/devicetree/bindings/leds/common.txt
> + - label : see Documentation/devicetree/bindings/leds/common.txt (deprecated)
> - linux,default-trigger :
> see Documentation/devicetree/bindings/leds/common.txt
>
> Example:
>
> +#include <dt-bindings/leds/common.h>
> +
> led-controller@2d {
> compatible = "ti,lp8860";
> #address-cells = <1>;
> @@ -36,7 +40,8 @@ led-controller@2d {
>
> led@0 {
> reg = <0>;
> - label = "white:backlight";
> + function = LED_FUNCTION_BACKLIGHT;
> + color = <LED_COLOR_ID_WHITE>;
> linux,default-trigger = "backlight";
> };
> }
>
Reviewed-by: Dan Murphy <dmurphy@xxxxxx>
--
------------------
Dan Murphy