Re: [PATCH net-next] rxrpc: Mark expected switch fall-through

From: David Howells
Date: Fri Apr 05 2019 - 11:15:56 EST

Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> wrote:

> /* Fall through and set IPv4 options too otherwise we don't get
> * errors from IPv4 packets sent through the IPv6 socket.
> */
> -
> + /* Fall through */

Er, no. Please (a) don't remove the blank line that's providing visual
separation and (b) observe that the previous comment already says "Fall
through" right at the beginning, so NAK.

If the compiler doesn't recognise this, then fix the compiler please.