Re: [patch V2 17/29] x86/exceptions: Disconnect IST index and stack order

From: Thomas Gleixner
Date: Fri Apr 05 2019 - 18:00:45 EST


On Fri, 5 Apr 2019, Josh Poimboeuf wrote:

> On Fri, Apr 05, 2019 at 05:07:15PM +0200, Thomas Gleixner wrote:
> > +/*
> > + * The exception stack ordering in [cea_]exception_stacks
> > + */
> > +enum exception_stack_ordering {
> > + ISTACK_DF,
> > + ISTACK_NMI,
> > + ISTACK_DB,
> > + ISTACK_MCE,
> > + N_EXCEPTION_STACKS
> > +};
>
> While clever, it reads as "interrupt stack" to me. ESTACK or IST_STACK
> would be infinitely better.

Fair enough.