Re: [PATCH] virtio: Honour 'may_reduce_num' in vring_create_virtqueue

From: Jens Freimann
Date: Mon Apr 08 2019 - 09:32:44 EST

On Mon, Apr 08, 2019 at 02:33:22PM +0200, Cornelia Huck wrote:
vring_create_virtqueue() allows the caller to specify via the
may_reduce_num parameter whether the vring code is allowed to
allocate a smaller ring than specified.

However, the split ring allocation code tries to allocate a
smaller ring on allocation failure regardless of what the
caller specified. This may cause trouble for e.g. virtio-pci
in legacy mode, which does not support ring resizing. (The
packed ring code does not resize in any case.)

Let's fix this by bailing out immediately in the split ring code
if the requested size cannot be allocated and may_reduce_num has
not been specified.

While at it, fix a typo in the usage instructions.

Fixes: 2a2d1382fe9d ("virtio: Add improved queue allocation API")
Cc: stable@xxxxxxxxxxxxxxx # v4.6+
Signed-off-by: Cornelia Huck <cohuck@xxxxxxxxxx>
drivers/virtio/virtio_ring.c | 2 ++
include/linux/virtio_ring.h | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Jens Freimann <jfreimann@xxxxxxxxxx>