Re: [patch V2 28/29] x86/irq/64: Remap the IRQ stack with guard pages
From: Andy Lutomirski
Date: Mon Apr 08 2019 - 12:18:15 EST
On Sun, Apr 7, 2019 at 11:46 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> On Sun, 7 Apr 2019, Andy Lutomirski wrote:
> > On Sun, Apr 7, 2019 at 3:44 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > > Actually we have: save_stack_trace()
> > >
> > Like I did here:
> > https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=WIP.x86/stackguards
> Kinda, but what that code wants is to skip any entry before 'caller'. So we
> either add something like save_stack_trace_from() which is trivial on x86
> because unwind_start() already has an argument to hand in the start of
> stack or we filter out the entries up to 'caller' in that code.
I could add a save_stack_trace_from() or I could add a "caller"
argument to struct stack_trace. Any preference as to which looks
better? The latter seems a little nicer to me.