Re: linux-next: Fixes tags need some work in the cifs tree

From: Steve French
Date: Mon Apr 08 2019 - 18:30:35 EST


I just fixed these up manually and repushed to cifs-2.6.git for-next

I was curious if checkpatch should have flagged this - I reran
checkpatch on the original version of Zhang's patches and it didn't
complain about the spacing (and probably should have).

On Mon, Apr 8, 2019 at 4:38 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> Hi all,
>
> In commit
>
> 7d672725ba72 ("cifs: Fix lease buffer length error")
>
> Fixes tags
>
> Fixes: 9764c02fcbad(SMB3: Add support for multidialect negotiate (SMB2.1 and later))
> Fixes: d5c7076b772a(smb3: add smb3.1.1 to default dialect list)
>
> has these problem(s):
>
> - missing space between the SHA1 and the subject
> - missing quotes around the subject
>
> In commit
>
> 54492efdd6a2 ("cifs: Fix use-after-free in SMB2_read")
>
> Fixes tag
>
> Fixes: eccb4422cf97(smb3: Add ftrace tracepoints for improved SMB3 debugging)
>
> has these problem(s):
>
> - missing space between the SHA1 and the subject
> - missing quotes around the subject
>
> In commit
>
> 3cc71735cf9f ("cifs: Fix use-after-free in SMB2_write")
>
> Fixes tag
>
> Fixes: eccb4422cf97(smb3: Add ftrace tracepoints for improved SMB3 debugging)
>
> has these problem(s):
>
> - missing space between the SHA1 and the subject
> - missing quotes around the subject
>
> --
> Cheers,
> Stephen Rothwell



--
Thanks,

Steve