Re: [PATCH] fat: issue flush after the writeback of FAT

From: OGAWA Hirofumi
Date: Tue Apr 09 2019 - 01:22:37 EST

"Darrick J. Wong" <darrick.wong@xxxxxxxxxx> writes:

>> + err = __generic_file_fsync(filp, start, end, datasync);
>> + if (err)
>> + return err;
>> - res = generic_file_fsync(filp, start, end, datasync);
>> err = sync_mapping_buffers(MSDOS_SB(inode->i_sb)->fat_inode->i_mapping);
> Huh. I would've thought that flushing the FAT would also be required
> at the end of a WB_SYNC_ALL (aka data integrity) writepages call?

In fatfs implement, FAT area is flushed by sync_mapping_buffers(fat_inode).
(FAT buffer is dirtied only by using bh->b_assoc_map to fat_inode)

OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>