Re: [PATCH] drm/qxl: drop prime import/export callbacks

From: Gerd Hoffmann
Date: Tue Apr 09 2019 - 04:47:23 EST


> > Should we add something like DRM_PRIME_CAP_SAME_DEVICE?
> Yeah I expect we need some sort of same device only capability, so
> that dri3 userspace can work.
> If we just fail importing in these cases what happens? userspace just
> gets confused, I know we used to print a backtrace if we hit the mmap
> path, but if we didn't do that what happens?

Well, we printed a backtrace and returned -EINVAL. So it looked a bit
scary due to the backtrace which is usually printed for more serious
problems. But we also returned a proper error code.

Userspace was not happy. It was wayland (gnome-shell) which ran into it
it, and it didn't came up with a working display.