Re: [PATCH] pinctrl: pinctrl-intel: move gpio suspend/resume to noirq phase
From: Andy Shevchenko
Date: Tue Apr 09 2019 - 11:28:51 EST
On Mon, Apr 08, 2019 at 03:51:26PM +0300, Mika Westerberg wrote:
> On Mon, Apr 08, 2019 at 03:43:48PM +0300, Andy Shevchenko wrote:
> > On Mon, Apr 08, 2019 at 06:49:26PM +0800, Binbin Wu wrote:
> > > In current driver, SET_LATE_SYSTEM_SLEEP_PM_OPS is used to install the
> > > callbacks for suspend/resume.
> > > GPIO pin may be used as the interrupt pin by some device. However, using
> > > SET_LATE_SYSTEM_SLEEP_PM_OPS() to install the callbacks, the resume
> > > callback is called after resume_device_irqs(). Unintended interrupts may
> > > arrive due to resuming device irqs first, but the GPIO controller is not
> > > properly restored.
> > >
> > > Normally, for a SMP system, there are multiple cores, so even when there are
> > > unintended interrupts, BSP gets the chance to init the gpio chip soon.
> > gpio -> GPIO.
> > (If Mika is okay with patch content, I may fix this when applying)
> Yup, this looks good to me.
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Pushed to my review and testing queue, thanks!
With Best Regards,