Re: [PATCH 2/2] module: Make srcu_struct ptr array as read-only post init

From: Mathieu Desnoyers
Date: Wed Apr 10 2019 - 00:20:53 EST


----- On Apr 9, 2019, at 11:38 PM, Joel Fernandes joelaf@xxxxxxxxxx wrote:

> On Tue, Apr 9, 2019 at 10:48 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>>
>> On Tue, 9 Apr 2019 22:41:03 -0400
>> Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote:
>>
>> > > Other than that, the two patches look fine to me.
>> >
>> > Could I add your Reviewed-by in the respin?
>>
>> You can add an Acked-by, as I haven't spent enough time to offer a
>> Reviewed-by tag. ;-)
>>
>> Maybe I'll get some time to vet it a bit more tomorrow, and then
>> upgrade the ack to a review.
>>
>> Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
>>
>
> Thanks!
>
> Also we could possibly consider adding the tracepoint ptrs array as
> well to the list, which would be useful I think, if one were to over
> write that array by accident (and the bpf tps related array too).

Yes, please!

Thanks,

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com