Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and randomizer support
From: Miquel Raynal
Date: Wed Apr 10 2019 - 03:16:21 EST
masonccyang@xxxxxxxxxxx wrote on Wed, 10 Apr 2019 09:14:14 +0800:
> Hi Boris,
> > Subject
> > Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and randomizer
> > On Tue, 9 Apr 2019 17:35:39 +0800
> > masonccyang@xxxxxxxxxxx wrote:
> > > > > +
> > > > > +static const struct kobj_attribute sysfs_mxic_nand =
> > > > > + __ATTR(nand_random, S_IRUGO | S_IWUSR,
> > > > > + mxic_nand_rand_type_show,
> > > > > + mxic_nand_rand_type_store);
> > > >
> > > > No, we don't want to expose that through a sysfs file, especially
> > > > changing the randomizer config means making the NAND unreadable for
> > > > those that have used it before the change.
> > > >
> > >
> > > Our on-die randomizer is still readable from user after the function
> > > is enabled.
> > You mean the memory is still readable no matter the randomizer state.
> > Not sure how that's possible, but okay.
So if you write non-randomized data to the NAND chip, then enable the
randomizer en read back the data, all will be ok?
And if randomized data is written to the NAND chip and we disable the
randomizer, then the data will also be correct?
> > > This randomizer is just like a internal memory cell
> > > reliability enhanced.
> > Why don't you enable it by default then?
> The penalty of randomizer is read/write performance down.
> i.e,. tPROG 300 us to 340 us (randomizer enable)
> therefore, disable it by default.
Is this info somewhere in the ONFI param page? I suppose once
randomization is enabled we should also tweak the timings and verify
that the controller supports it.
> > > It could be enable at any time with OTP bit function and that's why
> > > we patch it by sys-fs.
> > Sorry, but that's not a good reason to expose that through sysfs.
> Any good way to expose randomizer function for user ?
> thanks & best regards,