Re: [PATCH 1/4] PM / core: Introduce dpm_async_fn() helper

From: Rafael J. Wysocki
Date: Wed Apr 10 2019 - 04:17:33 EST


On Saturday, March 16, 2019 5:59:25 AM CEST Yangtao Li wrote:
> When we want to execute device pm functions asynchronously, we'll
> do the following for the device:
>
> 1) reinit_completion(&dev->power.completion);
> 2) Check if the device enables asynchronous suspend.
> 3) If necessary, execute the corresponding function asynchronously.
>
> There are a lot of such repeated operations here, in fact we can avoid
> this. So introduce dpm_async_fn() to have better code readability and
> reuse.
>
> And use this function to do some cleanup.
>
> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>

I'm queuing up this one, but the [2-4/4] are not convincing.

Thanks!