[RFC patch 04/41] sh/stacktrace: Remove the pointless ULONG_MAX marker

From: Thomas Gleixner
Date: Wed Apr 10 2019 - 07:08:04 EST


Terminating the last trace entry with ULONG_MAX is a completely pointless
exercise and none of the consumers can rely on it because it's
inconsistently implemented across architectures. In fact quite some of the
callers remove the entry and adjust stack_trace.nr_entries afterwards.

Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Rich Felker <dalias@xxxxxxxx>
Cc: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
Cc: linux-sh@xxxxxxxxxxxxxxx
Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx>
---
arch/sh/kernel/stacktrace.c | 4 ----
1 file changed, 4 deletions(-)

--- a/arch/sh/kernel/stacktrace.c
+++ b/arch/sh/kernel/stacktrace.c
@@ -49,8 +49,6 @@ void save_stack_trace(struct stack_trace
unsigned long *sp = (unsigned long *)current_stack_pointer;

unwind_stack(current, NULL, sp, &save_stack_ops, trace);
- if (trace->nr_entries < trace->max_entries)
- trace->entries[trace->nr_entries++] = ULONG_MAX;
}
EXPORT_SYMBOL_GPL(save_stack_trace);

@@ -84,7 +82,5 @@ void save_stack_trace_tsk(struct task_st
unsigned long *sp = (unsigned long *)tsk->thread.sp;

unwind_stack(current, NULL, sp, &save_stack_ops_nosched, trace);
- if (trace->nr_entries < trace->max_entries)
- trace->entries[trace->nr_entries++] = ULONG_MAX;
}
EXPORT_SYMBOL_GPL(save_stack_trace_tsk);