Re: [PATCH] lightnvm: pblk: fix crash in pblk_end_partial_read due to multipage bvecs

[Hans Holmberg]

On Wed, Apr 10, 2019 at 2:22 PM Javier GonzÃlez <javier@xxxxxxxxxxx> wrote:
>
> > On 8 Apr 2019, at 09.33, hans@xxxxxxxxxxxxx wrote:
> >
> > From: Hans Holmberg <hans.holmberg@xxxxxxxxxxxx>
> >
> > Ever since '07173c3ec276 ("block: enable multipage bvecs")' we
> > need to handle bios with multipage bvecs in pblk.
> >
> > Currently, a multipage bvec results in a crash[1].
> > Fix this by using bvec iterators in stead of direct bvec indexing.
> >
> > Also add a dcache flush, for the same reasons as in:
> > '6e6e811d747b ("block: Add missing flush_dcache_page() call")'
> >
> > [1] https://github.com/OpenChannelSSD/linux/issues/61
> >
> > Reported-by: Klaus Jensen <klaus.jensen@xxxxxxxxxxxx>
> > Signed-off-by: Hans Holmberg <hans.holmberg@xxxxxxxxxxxx>
> > ---
> >
> > It ain't pretty, but let's fix the breakage while waiting for Igor's
> > partial read cleanup to be ready.
> >
>
> I would prefer to have the real fix, but it is good to have this fixed for
> 5.2. Can we agree on a revert if Igor sends the patch within the 5.2
> window?

yeah! please chuck this patch out of the window when we have a nicer fix ready.

Thanks,
Hans