Re: [PATCH] firmware: arm_scmi: Fix leak in scmi_mailbox_check

From: Sudeep Holla
Date: Wed Apr 10 2019 - 11:50:06 EST


On Mon, Mar 25, 2019 at 05:37:22PM +0000, Steven Price wrote:
> of_parse_phandle_with_args() requires the caller to call of_node_put() on
> the returned args->np pointer. Otherwise the reference count will remain
> incremented.
>

Good find and thanks for the fix.

> However, in this case, since we don't actually use the returned pointer,
> we can simply pass in NULL.
>
> Fixes: aa4f886f3893f ("firmware: arm_scmi: add basic driver infrastructure for SCMI")
> Signed-off-by: Steven Price <steven.price@xxxxxxx>

Applied.

--
Regards,
Sudeep