Re: [PATCH v3 1/9] livepatch: Create and include UAPI headers

[Masahiro Yamada]

On Thu, Apr 11, 2019 at 12:52 AM Joe Lawrence <joe.lawrence@xxxxxxxxxx> wrote:
>
> From: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
>
> Define klp prefixes in include/uapi/linux/livepatch.h, and use them for
> replacing hard-coded values in kernel/livepatch/core.c.
>
> Update MAINTAINERS.
>
> Note: Add defines to uapi as these are also to be used by a newly
> introduced klp-convert script.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> Signed-off-by: Joao Moreira <jmoreira@xxxxxxx>
> Signed-off-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
> ---
>  MAINTAINERS                    |  1 +
>  include/linux/livepatch.h      |  1 +
>  include/uapi/linux/livepatch.h | 17 +++++++++++++++++
>  kernel/livepatch/core.c        |  4 ++--
>  4 files changed, 21 insertions(+), 2 deletions(-)
>  create mode 100644 include/uapi/linux/livepatch.h



> diff --git a/include/uapi/linux/livepatch.h b/include/uapi/linux/livepatch.h
> new file mode 100644
> index 000000000000..bb86243de805
> --- /dev/null
> +++ b/include/uapi/linux/livepatch.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: GPL-2.0 */


In my understanding, UAPI headers should be licensed under:

/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */


> +
> +/*
> + * livepatch.h - Kernel Live Patching Core
> + *
> + * Copyright (C) 2016 Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> + */
> +
> +#ifndef _UAPI_LIVEPATCH_H
> +#define _UAPI_LIVEPATCH_H
> +
> +#include <linux/types.h>


Why is this include needed?

> +#define KLP_RELA_PREFIX                ".klp.rela."
> +#define KLP_SYM_PREFIX         ".klp.sym."

These do not depend on <linux/types.h>



> +
> +#endif /* _UAPI_LIVEPATCH_H */



-- 
Best Regards
Masahiro Yamada