Re: [PATCH 2/2] x86/pci: Clean up usage of X86_DEV_DMA_OPS

From: Bjorn Helgaas
Date: Thu Apr 11 2019 - 09:35:50 EST


On Thu, Apr 11, 2019 at 07:18:49AM +0200, Christoph Hellwig wrote:
> On Wed, Apr 10, 2019 at 04:45:01PM -0500, Bjorn Helgaas wrote:
> > [+cc Keith, Jonathan (VMD guys)]
> >
> > I'm OK with this from a PCI perspective. It would be nice if
> >
> > dma_domain_list
> > dma_domain_list_lock
> > add_dma_domain()
> > del_dma_domain()
> > set_dma_domain_ops()
> >
> > could all be moved to vmd.c, since they're really only used there.
>
> I have another patch to eventually kill that, but it will need a little
> more prep work and thus be delayed to the next merge window.

Awesome, thanks! I really appreciate all the global cleanup work you do.

Bjorn