Re: [PATCH v4 4/4] ASoC: fsl_audmix: cache pdev->dev pointer
From: Nicolin Chen
Date: Thu Apr 11 2019 - 16:21:25 EST
On Wed, Apr 10, 2019 at 11:06:39AM +0000, Viorel Suman wrote:
> There should be no trouble to understand dev = pdev->dev.
> This can save some space to have more print info or save
> some wrapped lines.
Change looks fine. Ack.
> Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx>
> Suggested-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx>
I think usually Suggested-by comes above Signed-off-by.
This was originally in your change already, so you can replace:
-Suggested-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx>
-Acked-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx>
Just a chance for it to get resent without being a noise :)