Re: [PATCH 4/5] ARM: dts: rockchip: vcc33_ccd off in suspend for rk3288-veyron-chromebook

[elaine.zhang]

hi,

在 2019/4/12 上午7:21, Douglas Anderson 写道:
> As per my comments when the device tree for rk3288-veyron-chromebook
> first landed:
>
> > Technically I think vcc33_ccd can be off since we have
> > 'needs-reset-on-resume' down in the EHCI port (this regulator is for
> > the USB webcam that's connected to the EHCI port).
> >
> >   ...but leaving it on for now seems fine until we get suspend/resume
> > more solid.
> It's probably about time to do it right.
>
> [1] https://lore.kernel.org/linux-arm-kernel/CAD=FV=U37Yx8Mqk75_x05zxonvdc3qRMhqp8TyTDPWGHqSuRqg@xxxxxxxxxxxxxx/
>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
>
>   arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> index b9cc90f0f25c..fbef34578100 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> @@ -176,8 +176,7 @@
>   			regulator-min-microvolt = <3300000>;
>   			regulator-max-microvolt = <3300000>;
>   			regulator-state-mem {
> -				regulator-on-in-suspend;
> -				regulator-suspend-microvolt = <3300000>;
> +				regulator-off-in-suspend;
>   			};
>   		};
>   	};

Reviewed-by: Elaine Zhang<zhangqing@xxxxxxxxxxxxxx>